[Feat] #199 - 내가 그린 코스 상세 페이지를 변경 하였습니다.#201
Merged
thingineeer merged 16 commits intoRunnect:developfrom Dec 13, 2023
Hidden character warning
The head ref may contain hidden characters: "#199---\ub0b4\uac00-\uadf8\ub9b0-\ucf54\uc2a4-\uc0c1\uc138-\ud398\uc774\uc9c0-\ubcc0\uacbd"
Merged
Conversation
상세페이지에 시트를 추가 하였습니다.
513sojin
approved these changes
Dec 4, 2023
Collaborator
513sojin
left a comment
513sojin
left a comment
There was a problem hiding this comment.
코스 이름 연결 + 드롭다운 추가하신거 확인했습니다 ! 고생하셨어요
서버 요청 변수가 Scraps 에서 scraps 으로 변경 되었기 때문에 코드를 제거 합니다.
post 통신 API가 없어서 일단 코드만 작성 해놨습니다.
513sojin
reviewed
Dec 13, 2023
| let cellTitle = model.departure.name ?? " " | ||
|
|
||
| cell.setCellType(type: .title) | ||
| cell.selectCell(didSelect: collectionView.indexPathsForSelectedItems?.contains(indexPath) ?? false) |
Collaborator
There was a problem hiding this comment.
didSelect 부분에 삼항연산자를 써준 것 이외에 기존 코드를 바꾼 이유가 또 있나용?
Collaborator
Author
There was a problem hiding this comment.
옵셔널 체이닝 부분이였는데,
그냥 한줄로 표현 했습니다.. ㅎㅎ
| mapView.snp.makeConstraints { make in | ||
| make.edges.equalTo(view.safeAreaLayoutGuide) | ||
| make.leading.trailing.equalTo(self.view.safeAreaLayoutGuide) | ||
| make.top.equalTo(naviBar.snp.bottom) |
Collaborator
There was a problem hiding this comment.
네이버 로고를 보이게 해준 코드네요 ,, 확인 했습니다 ~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌱 작업한 내용
RunningWaitingVC()기능 추가🌱 PR Point
CourseStorageVC()에서 제목을 불러와야 하기 때문에 setData 함수도 이름도 가져오게 수정했습니다.CourseStorageVC()도 일부 수정+12 / 13
✅ 네이버 상표 뜨게 설정
📸 스크린샷
❌ 구현 전
default.mp4
✅ 구현 후
default.mp4
📮 관련 이슈